Improve logging #809
Improve logging #809
Conversation
|
|
|
@hiroshihorie @bcherry I decided to rewrite it from scratch (without waiting for v3), as the previous setup was kinda problematic in multiple ways. Let me know what you think, especially is there anything "harder to understand than before" for the consumer. The output looks nice(r) already, can be filtered more easily, etc.: 
|
|
@pblazej Nice, do we have a example app branch for this ? If not I'll make one. |
|
@hiroshihorie I think these are the only changes you need to make - feel free to test it in spare time 👍 (ofc you can even omit this change) 
|
|
|
||
| private let minLevel: LogLevel | ||
|
|
||
| public init(minLevel: LogLevel = .info, rtc: Bool = false) { |
There was a problem hiding this comment.
The default level is ofc opinionated here, we can go for .warning as well (no consensus on other platforms)... We use these logs sparingly, so for normal connection you just get a couple of messages.
2 participants
Turns out that the configuration closure:
If we need the flexibility anyway, maybe it's better to drop the
swift-loggingright now...My assupmtions: